sander/maps
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request 'fix: skip redundant mapController.move() on gesture-driven pans' (#1) from claude/relaxed-wright into main

Browse source 
Reviewed-on: #1
This commit is contained in:
sander 2026-04-04 14:06:34 +00:00
commit 4c8815f7cf
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
mobile/lib/features/map/presentation/screens/map_screen.dart
View file

@ -42,9 +42,18 @@ class _MapScreenState extends ConsumerState<MapScreen> {
final styleAsync = ref.watch(mapStyleProvider(apiClient.baseUrl)); final styleAsync = ref.watch(mapStyleProvider(apiClient.baseUrl));
// Listen for zoom/center changes from the provider and move the map. // Listen for zoom/center changes from the provider and move the map.
// Skip the move if the map controller is already at the target position
// (meaning the state change came from a user gesture via onPositionChanged).
// Without this guard, every gesture-driven pan calls _mapController.move()
// with the position the map is already at, which triggers a tile
// recalculation that cancels in-flight tile loads and produces a
// partially-rendered (diagonal) map.
ref.listen<MapState>(mapProvider, (previous, next) { ref.listen<MapState>(mapProvider, (previous, next) {
if (previous?.center != next.center || previous?.zoom != next.zoom) { if (previous?.center != next.center || previous?.zoom != next.zoom) {
_mapController.move(next.center, next.zoom); final camera = _mapController.camera;
if (camera.center != next.center || camera.zoom != next.zoom) {
_mapController.move(next.center, next.zoom);
}
} }
}); });