sander/rust-imap
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Try connection instead of unwrapping

Browse source 
Return an error instead of panicking on connection errors, which allows to
handle the problem from the caller.

fixes #12
This commit is contained in:
Miquel Ruiz 2016-06-05 12:47:46 +01:00
parent 0cbe8dbd10
commit 6816b922f0
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/client.rs
View file

@ -31,7 +31,7 @@ impl IMAPStream {
pub fn connect<S: Into<String>>(host: S, port: u16, ssl_context: Option<SslContext>) -> Result<IMAPStream> {
let host_string = host.into();
let connect_string = format!("{}:{}", host_string, port);
let tcp_stream = TcpStream::connect(&*connect_string).unwrap();
let tcp_stream = try!(TcpStream::connect(&*connect_string));
let mut socket = match ssl_context {
Some(context) => IMAPStream { stream: IMAPStreamTypes::Ssl(SslStream::connect(&context, tcp_stream).unwrap()), host: host_string, port: port, tag: 1, tag_prefix: "a"},
None => IMAPStream { stream: IMAPStreamTypes::Basic(tcp_stream), host: host_string, port: port, tag: 1, tag_prefix: "a"},
@ -334,3 +334,9 @@ impl IMAPStream {
return command;
}
}
#[test]
fn connect() {
let imap = IMAPStream::connect("this-is-not-an-imap-server", 143, None);
assert!(imap.is_err());
}