comments

lib/src/main/java/com/github/shautvast/exceptional/ExceptionLogger.java

@@ -10,6 +10,7 @@ public class ExceptionLogger {
     public static void log(Throwable throwable) {
         try {
             // use json for now because of ease of integration
+            // would compression be useful?? use snappy?
             if (throwable != null) {
                 bufferWriter.put(objectMapper.writeValueAsBytes(throwable));
             }

lib/src/main/java/com/github/shautvast/exceptional/MPSCBufferWriter.java

@@ -29,7 +29,7 @@ public class MPSCBufferWriter implements AutoCloseable {
 
             // setup of native memory ringbuffer
             var arena = Arena.ofConfined();
-            var ringbufferMemory = arena.allocate(0xffff);
+            var ringbufferMemory = arena.allocate(32768);
             var buffer = new CircularByteBuffer(ringbufferMemory);
 
             arena = Arena.ofConfined();

lib/src/test/java/com/github/shautvast/exceptional/ExceptionLoggerTest.java

@@ -9,7 +9,7 @@ class ExceptionLoggerTest {
     @Test
     void test() throws InterruptedException {
         ExceptionLogger.log(new Throwable());
-        TimeUnit.SECONDS.sleep(30);
+        TimeUnit.SECONDS.sleep(1);
     }
 
 }

rustlib/src/lib.rs

@@ -2,6 +2,9 @@ use std::ffi::c_char;
 
 mod throwable;
 
+// same value, but different meanings
+// TODO find a way to set the buffer size from java.
+// why not just add it to the function
 const CAPACITY: isize = 32760;
 const READ: isize = 32760;