From 9477e68e18644d34f12f93558e9d29caefde7c50 Mon Sep 17 00:00:00 2001
From: Shautvast <shautvast@gmail.com>
Date: Tue, 22 Oct 2024 12:07:11 +0200
Subject: [PATCH] separated implementation from headers for the Expression
 classes

---
 src/parser.cpp | 63 +++++++++++++++++++++++++++++++++++++++++
 src/parser.hpp | 77 +++++++++++++++++---------------------------------
 2 files changed, 89 insertions(+), 51 deletions(-)

diff --git a/src/parser.cpp b/src/parser.cpp
index 5156459..08b0415 100644
--- a/src/parser.cpp
+++ b/src/parser.cpp
@@ -1,5 +1,68 @@
 #include "parser.hpp"
 
+Expression::~Expression() {}
+
+// class Binary
+ExprType Binary::get_type() { return ExprType::Binary; }
+
+std::string Binary::to_string() {
+  return "(" + token_name(op->tokentype) + " " + left->to_string() + " " +
+         right->to_string() + ")";
+}
+
+Binary::Binary(Expression *_left, Token *_operator, Expression *_right)
+    : left(_left), op(_operator), right(_right){};
+
+Binary::~Binary() {
+  delete left;
+  delete right;
+  delete op;
+}
+
+// class Grouping
+ExprType Grouping::get_type() { return ExprType::Grouping; }
+
+std::string Grouping::to_string() { return "(" + expr->to_string() + ")"; }
+
+Grouping::Grouping(Expression *_expr) : expr(_expr){};
+
+Grouping::~Grouping() { delete expr; }
+
+// class Unary
+ExprType Unary::get_type() { return ExprType::Unary; }
+
+std::string Unary::to_string() {
+  return token_name(op->tokentype) + right->to_string();
+}
+
+Unary::Unary(Token *_operator, Expression *_right)
+    : op(_operator), right(_right){};
+
+Unary::~Unary() {
+  delete right;
+  delete op;
+}
+
+// class Literal
+std::string Literal::to_string() {
+  std::string text;
+  switch (valuetype) {
+  case String:
+    text = "\"" + value.str + "\"";
+    break;
+  case Numeric:
+    text = std::to_string(value.numeric);
+    break;
+  case Boolean:
+    text = value.boolean ? "True" : "False";
+    break;
+  case Nil:
+    text = "NULL";
+    break;
+  }
+  return text;
+}
+
 Expression *Parser::parse(std::vector<Token> tokenlist) {
   tokens = tokenlist;
   current_token = 0;
diff --git a/src/parser.hpp b/src/parser.hpp
index 0d9272a..a6b2ec3 100644
--- a/src/parser.hpp
+++ b/src/parser.hpp
@@ -12,54 +12,46 @@ class Expression {
 public:
   virtual ExprType get_type() = 0;     // abstract, getter for tyoe
   virtual std::string to_string() = 0; // abstract, string rep for debugging
-  virtual ~Expression() = 0;           // destructor
+  virtual ~Expression();               // destructor
 };
 
 /// An expression with two operands
 class Binary : public Expression {
-public:
-  ExprType get_type() override { return ExprType::Binary; }
-  std::string to_string() override {
-    return "(" + token_name(op->tokentype) + " " + left->to_string() + " " +
-           right->to_string() + ")";
-  }
+private:
   Expression *left;
   Token *op;
   Expression *right;
-  Binary(Expression *_left, Token *_operator, Expression *_right)
-      : left(_left), op(_operator), right(_right){};
-  ~Binary() override {
-    delete left;
-    delete right;
-    delete op;
-  }
+
+public:
+  ExprType get_type() override;
+  std::string to_string() override;
+  Binary(Expression *_left, Token *_operator, Expression *_right);
+  ~Binary();
 };
 
 /// An expression between parentheses
 class Grouping : public Expression {
-public:
-  ExprType get_type() override { return ExprType::Grouping; }
-  std::string to_string() override { return "(" + expr->to_string() + ")"; }
+private:
   Expression *expr;
-  Grouping(Expression *_expr) : expr(_expr){};
-  ~Grouping() override { delete expr; }
+
+public:
+  ExprType get_type() override;
+  std::string to_string() override;
+  Grouping(Expression *_expr);
+  ~Grouping();
 };
 
 /// An expression with one operand (operator is `-`  or `!`)
 class Unary : public Expression {
-public:
-  ExprType get_type() override { return ExprType::Unary; }
-  std::string to_string() override {
-    return token_name(op->tokentype) + right->to_string();
-  }
+private:
   Token *op;
   Expression *right;
 
-  Unary(Token *_operator, Expression *_right) : op(_operator), right(_right){};
-  ~Unary() override {
-    delete right;
-    delete op;
-  }
+public:
+  ExprType get_type() override;
+  std::string to_string() override;
+  Unary(Token *_operator, Expression *_right);
+  ~Unary();
 };
 
 /// empty class that is the type of the Nil value
@@ -85,29 +77,12 @@ public:
     ~Value() {}
   } value;
 
-  Literal(Void v) : valuetype(ValueType::Nil), value(v) {}
-  Literal(double_t _numeric) : valuetype(ValueType::Numeric), value(_numeric) {}
-  Literal(std::string _str) : valuetype(ValueType::String), value(_str) {}
-  Literal(bool _boolean) : valuetype(ValueType::Boolean), value(_boolean) {}
+  Literal(Void v) : valuetype(ValueType::Nil), value(v){};
+  Literal(double_t _numeric) : valuetype(ValueType::Numeric), value(_numeric){};
+  Literal(std::string _str) : valuetype(ValueType::String), value(_str){};
+  Literal(bool _boolean) : valuetype(ValueType::Boolean), value(_boolean){};
 
-  std::string to_string() override {
-    std::string text;
-    switch (valuetype) {
-    case String:
-      text = "\"" + value.str + "\"";
-      break;
-    case Numeric:
-      text = std::to_string(value.numeric);
-      break;
-    case Boolean:
-      text = value.boolean ? "True" : "False";
-      break;
-    case Nil:
-      text = "NULL";
-      break;
-    }
-    return text;
-  }
+  std::string to_string() override;
 };
 
 class Parser {