sander/Contiguous
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

more convenient mapper

Browse source
This commit is contained in:
Shautvast 2023-05-28 17:38:23 +02:00
parent c6ef047835
commit b558c89e24
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
jdbc/src/main/java/nl/sanderhautvast/contiguous/JdbcResults.java
View file

@ -41,7 +41,13 @@ public class JdbcResults {
String fieldName = next.getFieldName();
Object fieldValue;
if (fieldName != null) {
fieldValue = result.getObject(fieldNameMapper.apply(fieldName));
String columnName = fieldNameMapper.apply(fieldName);
if (columnName == null) {
columnName = fieldName;
} // would it be usefull if we could add this to the state (convert Function<> to Map<>)?
// so that next time the entry would be in the map...
// -> more branch predicability for the `if`
fieldValue = result.getObject(columnName);
} else {
// assume single Primitive as Contiguous<String>, so just 1 column in the record
fieldValue = result.getObject(1);

4
jdbc/src/test/java/nl/sanderhautvast/contiguous/JdbcResultsTest.java
View file

@ -56,7 +56,7 @@ class JdbcResultsTest {
when(mockResults.getObject("name")).thenReturn("Trillian");
when(mockResults.getObject("realName")).thenReturn("Tricia MacMillan");
Map<String, String> nameMapping = Map.of("name", "name", "earthName", "realName");
Map<String, String> nameMapping = Map.of("earthName", "realName");
List<Scientist> scientists = JdbcResults.toList(mockResults, Scientist.class, nameMapping::get);
assertFalse(scientists.isEmpty());
@ -66,6 +66,4 @@ class JdbcResultsTest {
assertEquals("Trillian", scientist.getName());
assertEquals("Tricia MacMillan", scientist.getEarthName());
}
}